No Mirador for images when IIIF bridge is unset #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an Item has files, but there is no IIIF bridge set up, there shouldn't be a IIIF viewer displayed unless the Item has IIIF JSON data associated with it. Previously, if there were no bridge set up, Items without manifests would display an empty Mirador viewer as long as they had IIIF-compatible files associated with them. I found this out on a site where we don't have a IIIF server set up, but we still want to take advantage of externally hosted IIIF-compatible images and annotate those, while also having images that we had uploaded ourselves.
Closed
|
Thank you for your suggestion. The external-only use case should look a lot better with this modification in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an Item has files, but there is no IIIF bridge set up, there shouldn't be a IIIF viewer displayed unless the Item has IIIF JSON data associated with it.
Previously, if there were no bridge set up, Items without manifests would display an empty Mirador viewer as long as they had IIIF-compatible files associated with them.
I found this out on a site where we don't have a IIIF server set up, but we still want to take advantage of externally hosted IIIF-compatible images and annotate those, while also having images that we had uploaded ourselves.