Support drive resizing #4087
Closed
Support drive resizing #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UTMLogToMemory to capture output of "qemu-img info", which we can parse the JSON output of in order to determine the virtual size of the drive. Use the same widget style for resizing as we do for creating a drive (GB/MB), although require clicking "Resize" to do the resize itself. Currently doesn't warn about having not clicked "resize" though.
stewartsmith
force-pushed
the
resize-drives
branch
from
f5897f1
to
bcf826b
Compare
osy
force-pushed
the
master
branch
3 times, most recently
from
fb33cb2
to
3260ced
Compare
|
Thanks for the PR. There has been a lot of changes to the backend, so I picked up your changes to UTMQemuImage (using the new delegate interface for UTMLogging) and then reworked the UI to be coherent across all the different disk operations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UTMLogToMemory to capture output of "qemu-img info", which we can parse the JSON output of in order to determine the virtual size of the drive.
Use the same widget style for resizing as we do for creating a drive (GB/MB), although require clicking "Resize" to do the resize itself.
Currently doesn't warn about having not clicked "resize" though.
Fair warning: I'm pretty sure this is the first time in nearly 20 years I've looked at Objective-C code, and my Swift knowledge is sketchy at best.