Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netcore Email adapter #53

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

codingmickey
Copy link

As I'm still yet to receive the test account and credits from Netcore I'm making this a draft PR, as I wrote the code and tests by referring to their API docs

What does this PR do?

This PR adds Netcore email adapter along with tests.

Test Plan

Check the first line I'll update once I get a Netcore account or if someone already has one test account that can be really helpful to test, As their email API doesn't include direct free testing account signups currently
image

Related PRs and Issues

Closes appwrite/appwrite#6394

Have you read the Contributing Guidelines on issues?

Yes

Signed-off-by: Kartik Jolapara <kjmickey003@gmail.com>
Signed-off-by: Kartik Jolapara <kjmickey003@gmail.com>
Signed-off-by: Kartik Jolapara <kjmickey003@gmail.com>
@codingmickey codingmickey marked this pull request as ready for review October 31, 2023 04:34
@gewenyu99
Copy link

Hey,

Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.

When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.

Thanks for helping us improve Appwrite!

@codingmickey
Copy link
Author

What would be the next process of getting merged.. as I still haven't been contacted by the Netcore team for a free trial account to test these :(

@gewenyu99
Copy link

@codingmickey Since the PR is approved, there is nothing more on your side. We will merge these PRs, nothing more required from you :D

@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💬 Improve Appwrite Messaging with Netcore Adapter
3 participants