-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/use kotlin preprocessors plugin #483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chippmann
approved these changes
Jul 23, 2023
Could we merge that after #474? |
piiertho
force-pushed
the
feature/use-kotlin-preprocessors-plugin
branch
from
July 25, 2023 09:25
e41aae1
to
a17d0d5
Compare
chippmann
approved these changes
Aug 9, 2023
piiertho
force-pushed
the
feature/use-kotlin-preprocessors-plugin
branch
from
October 19, 2023 06:48
a17d0d5
to
a39eeed
Compare
piiertho
force-pushed
the
feature/use-kotlin-preprocessors-plugin
branch
from
October 19, 2023 07:27
a39eeed
to
fdfe8ba
Compare
Some documentation should be written so users know how they are supposed to build with the release library. |
Added a small documentation about compiling. |
piiertho
force-pushed
the
feature/use-kotlin-preprocessors-plugin
branch
from
October 20, 2023 06:23
fcfbd09
to
b821f07
Compare
piiertho
force-pushed
the
feature/use-kotlin-preprocessors-plugin
branch
from
October 20, 2023 15:42
03d35cb
to
b9e96cc
Compare
piiertho
force-pushed
the
feature/use-kotlin-preprocessors-plugin
branch
from
October 20, 2023 21:09
b9e96cc
to
aaba7d3
Compare
CedNaru
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of new kotlin-preprocessors gradle plugin.
This creates a
debug
andrelease
version ofgodot-library
, which is now published undergodot-library-debug
andgodot-library-release
. Add-Prelease
when buildinggodot-library
to buildrelease
version, default isdebug
.Godot Kotlin gradle plugins now check presence of
release
parameter. If it is present, it will fetchgodot-library-release
, otherwise it will fetchgodot-library-debug
.This does not build when exporting, this should be done in another PR.