Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use kotlin preprocessors plugin #483

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

piiertho
Copy link
Member

@piiertho piiertho commented Jul 22, 2023

This makes use of new kotlin-preprocessors gradle plugin.
This creates a debug and release version of godot-library, which is now published under godot-library-debug and godot-library-release. Add -Prelease when building godot-library to build release version, default is debug.
Godot Kotlin gradle plugins now check presence of release parameter. If it is present, it will fetch godot-library-release, otherwise it will fetch godot-library-debug.

This does not build when exporting, this should be done in another PR.

@piiertho piiertho added the enhancement New feature or request label Jul 22, 2023
@piiertho piiertho self-assigned this Jul 22, 2023
@chippmann
Copy link
Contributor

Could we merge that after #474?

@piiertho piiertho force-pushed the feature/use-kotlin-preprocessors-plugin branch from e41aae1 to a17d0d5 Compare July 25, 2023 09:25
@piiertho piiertho force-pushed the feature/use-kotlin-preprocessors-plugin branch from a17d0d5 to a39eeed Compare October 19, 2023 06:48
@piiertho piiertho force-pushed the feature/use-kotlin-preprocessors-plugin branch from a39eeed to fdfe8ba Compare October 19, 2023 07:27
@CedNaru
Copy link
Member

CedNaru commented Oct 19, 2023

Some documentation should be written so users know how they are supposed to build with the release library.

@piiertho
Copy link
Member Author

piiertho commented Oct 19, 2023

Some documentation should be written so users know how they are supposed to build with the release library.

Added a small documentation about compiling.

@piiertho piiertho force-pushed the feature/use-kotlin-preprocessors-plugin branch from fcfbd09 to b821f07 Compare October 20, 2023 06:23
@piiertho piiertho force-pushed the feature/use-kotlin-preprocessors-plugin branch from 03d35cb to b9e96cc Compare October 20, 2023 15:42
@piiertho piiertho force-pushed the feature/use-kotlin-preprocessors-plugin branch from b9e96cc to aaba7d3 Compare October 20, 2023 21:09
@piiertho piiertho merged commit e3957fd into master Oct 24, 2023
35 checks passed
@piiertho piiertho deleted the feature/use-kotlin-preprocessors-plugin branch October 24, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the new Kotlin debug preprocessor in core types.
3 participants