Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border radius should be in percent? #8

Closed
josteinhanssen opened this issue Oct 20, 2015 · 6 comments
Closed

Border radius should be in percent? #8

josteinhanssen opened this issue Oct 20, 2015 · 6 comments

Comments

@josteinhanssen
Copy link

I suggest changing the default setting for the border-radius to: 'border-radius:50%;'. This way it will always be a completly round shape.

The way it is now, it renders as squares with rounded corners when the size gets bigger (ie 120x120).

@uttesh
Copy link
Owner

uttesh commented Oct 20, 2015

@josteinhanssen thanks for the input, we will update that in next release.

@oglematt
Copy link

@uttesh, When can we expect to see this change? I'd be happy to put it together in a PR, but it's quite literally a single line change from 30px to 50%. If you'd like me to make the adjustment and submit a PR, please let me know. Thanks!

@uttesh
Copy link
Owner

uttesh commented Feb 21, 2016

@oglematt thanks , that property is already updated in library, may be i missed to update in the read me page/file, i will update now.

@oglematt
Copy link

@uttesh, Thanks for the reply. I see that it's on master, but it doesn't appear to have made it to a release. I used bower and that shows that the border radius is still set to 30% and the latest release (4.0.0) also shows 30%.

@uttesh
Copy link
Owner

uttesh commented Feb 23, 2016

oh thanks @oglematt i will update the bower and npm libs

@oglematt
Copy link

@uttesh, Fantastic. Thank you!

sean-stanley added a commit to sean-stanley/ngletteravatar that referenced this issue Feb 27, 2016
this should fix issue uttesh#8
sean-stanley pushed a commit to sean-stanley/ngletteravatar that referenced this issue Feb 27, 2016
@uttesh uttesh closed this as completed Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants