Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error message consistent with GNU diff's implementation when failing to read input file(s) #63

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

oSoMoN
Copy link
Collaborator

@oSoMoN oSoMoN commented Apr 23, 2024

No description provided.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.52%. Comparing base (d362046) to head (8a3a977).

Files Patch % Lines
src/params.rs 95.00% 0 Missing and 2 partials ⚠️
tests/integration.rs 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   82.48%   75.52%   -6.97%     
==========================================
  Files          10       10              
  Lines        2935     2929       -6     
  Branches      744      746       +2     
==========================================
- Hits         2421     2212     -209     
+ Misses        495      490       -5     
- Partials       19      227     +208     
Flag Coverage Δ
macos_latest ?
ubuntu_latest 75.92% <95.52%> (+0.47%) ⬆️
windows_latest 15.87% <29.85%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oSoMoN oSoMoN force-pushed the io-error-msg branch 2 times, most recently from 92db007 to 72a43c8 Compare April 30, 2024 16:52
@oSoMoN oSoMoN requested a review from sylvestre June 4, 2024 13:30
@sylvestre sylvestre merged commit 468c4bf into uutils:main Jun 27, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants