-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdin: Handle directory input #73
base: main
Are you sure you want to change the base?
Conversation
When handling stdin, GNU diff now behaves as follows: * If a file is input, it displays the current time as m_time * If a directory is input, it appends the other file_name to the canonicalized path of directory and reads and displays the m_time of that file
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 75.46% 75.12% -0.35%
==========================================
Files 10 10
Lines 2935 2959 +24
Branches 745 754 +9
==========================================
+ Hits 2215 2223 +8
- Misses 547 557 +10
- Partials 173 179 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Okay, now this is tricky! There is no |
b815cf0
to
f21689d
Compare
Hey @oSoMoN , can you review this PR? |
Sorry for the long delay @TanmayPatil105, I haven't had time to dedicate to this project in the last few weeks. |
Yeah, that is highly unlikely. However, since GNU diff 3.9, it has started handling redirected directory inputs. Additionally, this has also been included in the tests http://git.savannah.gnu.org/cgit/diffutils.git/tree/tests/stdin#n27.
I had a go on it but I don't think so there's a way to redirect a directory as input through code. Is there a way? |
When handling stdin, GNU diff now behaves as follows: