Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the diffutils binary to diff, #75

Closed
wants to merge 1 commit into from

Conversation

oSoMoN
Copy link
Collaborator

@oSoMoN oSoMoN commented Jun 4, 2024

in preparation for the future implementation of other binaries (cmp, sdiff and diff3)

in preparation for the future implementation of other binaries (cmp, sdiff and diff3)
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 75.06%. Comparing base (d362046) to head (9a7d8c8).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
tests/integration.rs 0.00% 0 Missing and 16 partials ⚠️

❗ There is a different number of reports uploaded between BASE (d362046) and HEAD (9a7d8c8). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (d362046) HEAD (9a7d8c8)
ubuntu_latest 2 1
macos_latest 2 0
windows_latest 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   82.48%   75.06%   -7.42%     
==========================================
  Files          10       10              
  Lines        2935     2876      -59     
  Branches      744      744              
==========================================
- Hits         2421     2159     -262     
  Misses        495      495              
- Partials       19      222     +203     
Flag Coverage Δ
macos_latest ?
ubuntu_latest 75.45% <0.00%> (ø)
windows_latest 15.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre
Copy link
Collaborator

what is your plan here? Create new binaries ?

What about doing the same as coreutils ? One main binaries (or individual programs)
and if you do ln -s diffutils diff or ln -s diffutils cmp, it will change the behavior of the command.

@oSoMoN
Copy link
Collaborator Author

oSoMoN commented Jun 4, 2024

I was thinking of individual binaries, but I must admit I didn't look at how it's done for coreutils, and I suppose it makes sense to do something similar. I'll take a look later, in the meantime I'm leaving this PR open.

@oSoMoN oSoMoN marked this pull request as draft June 4, 2024 18:28
@sylvestre
Copy link
Collaborator

the main adv is the size of the binaries as Rust bins have a tendency to be bigger than C :)

@oSoMoN
Copy link
Collaborator Author

oSoMoN commented Sep 26, 2024

Closing, as this is definitely being obsoleted by Gustavo's work in #88.

@oSoMoN oSoMoN closed this Sep 26, 2024
@oSoMoN oSoMoN deleted the several-binaries branch September 26, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants