Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -xdev #136

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Add support for -xdev #136

merged 1 commit into from
Jan 27, 2022

Conversation

refi64
Copy link
Contributor

@refi64 refi64 commented Jan 26, 2022

Unfortunately, the nature of this makes it incredibly hard to test for
in CI; not even BFS's massive test suite covers it. That being said,
it's a simple enough addition that the risk it incurs hopefully
shouldn't be too large.

Signed-off-by: Ryan Gonzalez ryan.gonzalez@collabora.com

Unfortunately, the nature of this makes it incredibly hard to test for
in CI; not even BFS's massive test suite covers it. That being said,
it's a simple enough addition that the risk it incurs hopefully
shouldn't be too large.

Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #136 (0a8b72f) into main (1517cc0) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   52.52%   52.50%   -0.03%     
==========================================
  Files          23       23              
  Lines        4655     4659       +4     
  Branches     1531     1532       +1     
==========================================
+ Hits         2445     2446       +1     
- Misses       1664     1666       +2     
- Partials      546      547       +1     
Impacted Files Coverage Δ
src/find/matchers/mod.rs 63.88% <0.00%> (-0.77%) ⬇️
src/find/mod.rs 61.79% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1517cc0...0a8b72f. Read the comment docs.

@sylvestre
Copy link
Contributor

For others:

       -xdev  Don't descend directories on other filesystems.

@sylvestre sylvestre merged commit 78eba7e into uutils:main Jan 27, 2022
@tavianator
Copy link
Contributor

not even BFS's massive test suite covers it

Actually ./tests.sh --sudo does cover it, but it needs sudo access. And it's probably not directly useful to uutils since --sudo also tests some bfs-specific extensions. There's no way (yet) to ask for the --sudo tests that are GNU compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants