find: Don't swallow mkfifo errors in the tests #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use nix's version of mkfifo instead, which lets us easily access the errors and then fail with more information than the FIFO mysteriously not appearing. Ref. uutils#177. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 49.03% 49.12% +0.09%
==========================================
Files 30 30
Lines 4913 4914 +1
Branches 1290 1297 +7
==========================================
+ Hits 2409 2414 +5
+ Misses 1849 1843 -6
- Partials 655 657 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use nix's version of mkfifo instead, which lets us easily access the
errors and then fail with more information than the FIFO mysteriously
not appearing.
Ref. #177.
Signed-off-by: Ryan Gonzalez ryan.gonzalez@collabora.com