python: Remove coltedb dependency on psycopg2 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psycopg2 is only needed when communicating with postgres, which should only be required when using the metering functionality. The base install should not require a database connection. Before this commit the base coltedb wrapper was creating a database connection and then passing it into the different implementation functions. This meant the database connection library was required, even if the connection was never needed. This commit moves the connection creation into each prepaid billing function. This does result in a lot of duplication, and in-general the organization of the coltedb base script and the specialization scripts could be improved a lot.
matt9j
force-pushed
the
devel-no-base-psycopg2
branch
from
c951f48
to
1cde6cf
Compare
|
Build is likely failing due to this upstream change in github actions: actions/runner-images#4797 Will require an update to the install workflow in the action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
psycopg2 is only needed when communicating with postgres, which should
only be required when using the metering functionality. The base
install should not require a database connection. Before this commit
the base coltedb wrapper was creating a database connection and then
passing it into the different implementation functions. This meant the
database connection library was required, even if the connection was
never needed. This commit moves the connection creation into each
prepaid billing function.
This does result in a lot of duplication, and in-general the
organization of the coltedb base script and the specialization scripts
could be improved a lot.