Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing decoding to match live restclient calls #48

Merged
merged 5 commits into from
Aug 9, 2018

Conversation

ezturner
Copy link
Contributor

@ezturner ezturner commented Aug 6, 2018

No description provided.

@ezturner ezturner requested a review from jlaney August 6, 2018 18:06
@coveralls
Copy link

coveralls commented Aug 6, 2018

Coverage Status

Coverage decreased (-5.4%) to 85.665% when pulling 0b9ae8b on bug/memcached-mock-error into 958b5bb on develop.

@ezturner
Copy link
Contributor Author

ezturner commented Aug 6, 2018

The encoding of the mock data response/file contents doesn't match the live restclient calls, and this is causing the memcached layer to fail when I feed it mock data.

@ezturner ezturner force-pushed the bug/memcached-mock-error branch 3 times, most recently from 0a7afbf to c58c4a1 Compare August 8, 2018 20:43
@ezturner ezturner force-pushed the bug/memcached-mock-error branch 2 times, most recently from 6d68d21 to 0b9ae8b Compare August 8, 2018 21:20
@ezturner ezturner merged commit 3a5f786 into develop Aug 9, 2018
@ezturner ezturner deleted the bug/memcached-mock-error branch August 9, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants