Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context to methods #6

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Add context to methods #6

merged 1 commit into from
Oct 18, 2019

Conversation

johanbrandhorst
Copy link
Contributor

@johanbrandhorst johanbrandhorst commented Oct 15, 2019 •
edited
Loading

Also changes docker implementation to use official client instead of dockertest/go-dockerclient.

@codecov-io
Copy link

codecov-io commented Oct 16, 2019 •
edited
Loading

Codecov Report

Merging #6 into master will increase coverage by 1.81%.
The diff coverage is 71.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   54.46%   56.27%   +1.81%     
==========================================
  Files           4        4              
  Lines         213      247      +34     
==========================================
+ Hits          116      139      +23     
- Misses         66       74       +8     
- Partials       31       34       +3
Impacted Files Coverage Δ
runtimes/docker/config.go 55.55% <62.5%> (+14.37%) ⬆️
runtimes/docker/docker.go 65.16% <69.35%> (-0.35%) ⬇️
runtimes/podman/podman.go 50% <78.78%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9c8ea...c29118d. Read the comment docs.

johanbrandhorst
johanbrandhorst commented Oct 16, 2019
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@johanbrandhorst johanbrandhorst force-pushed the use-varlink-context branch 2 times, most recently from 6bf7471 to da6cf5f Compare October 16, 2019 16:01
johanbrandhorst
johanbrandhorst commented Oct 16, 2019
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@johanbrandhorst johanbrandhorst force-pushed the use-varlink-context branch 3 times, most recently from e2200fb to 4512fc0 Compare October 17, 2019 09:03
@johanbrandhorst johanbrandhorst mentioned this pull request Oct 17, 2019
Merged
@johanbrandhorst
Add context to methods
c29118d 
Also changes docker implementation
to use official client instead of
dockertest/go-dockerclient.
@johanbrandhorst johanbrandhorst marked this pull request as ready for review October 18, 2019 15:34
@johanbrandhorst johanbrandhorst changed the title WIP Add context to methods Oct 18, 2019
@johanbrandhorst johanbrandhorst merged commit 53c9f0e into master Oct 18, 2019
@johanbrandhorst johanbrandhorst deleted the use-varlink-context branch October 18, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanbrandhorst @codecov-io