I104 introduction documents

[frinzekt]

Closes #104
and

• make comment optional to mark as read

[MouseAndKeyboard]

Looks good

[MouseAndKeyboard]

Why did you chain the ternary operators here.
Do you envision having tags which are text or something (not EOCs or EOC groups)?

[frinzekt]

Yes, "introduction" tags.

…

On Mon, 8 Feb 2021, 9:30 pm MouseAndKeyboard, ***@***.***> wrote: ***@***.**** approved this pull request. Looks good ------------------------------ In client/components/Coordinator/EvaluationOverview/Documents/DocumentCard.js <#105 (comment)> : > ); } }; - const badges = tags.map((eoc) => ( - <Badge key={eoc} color={eoc.includes('.') ? 'info' : 'primary'}> - EOC: {eoc} - </Badge> - )); + const badges = tags.map(tag=>{ + const isEOC = Boolean(parseFloat(tag)); // Non-floating point are false + const color = isEOC ? + tag.includes('.') ? 'info' : 'primary' : Why did you chain the ternary operators here. Do you envision having tags which are text or something (not EOCs or EOC groups)? ------------------------------ In client/components/Coordinator/EvaluationOverview/Documents/EditModal.js <#105 (comment)> : > - {eocs.map((numberLabel) => ( - <DesignedCheckBox - key={numberLabel} - onClick={() => handleCheck(numberLabel)} - isChecked={tags.includes(numberLabel)} - label={`EOC ${numberLabel}`} - /> - ))} + {tagsAllowed.map((tag) => { + const isEOC = Boolean(parseFloat(tag)); // Non-floating point are false + return( + <DesignedCheckBox + key={tag} + onClick={() => handleCheck(tag)} + isChecked={tagsSelected.includes(tag)} + label={isEOC ? `EOC ${tag}` : tag} Yep, I understand now. You may want tags which aren't EOCs. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#105 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKSVXXK6BWULDEJ7TSRNLKDS57ROLANCNFSM4XE4FKEQ> .