Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numbers in MSP #296

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Allow numbers in MSP #296

merged 1 commit into from
Jun 24, 2023

Conversation

ChinemeremChigbo
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo commented May 21, 2023

Doctor's MSP no longer only accepts numbers to be entered

Notion ticket link

Doctor's MSP only accepts numbers to be entered

Implementation description

Notes

  • Should all characters be allowed? Or only letters and numbers? I have currently implemented it such that anything can be entered.

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

Doctor's MSP no longer only accepts numbers to be entered
@ChinemeremChigbo ChinemeremChigbo merged commit 061d545 into staging Jun 24, 2023
1 check passed
@ChinemeremChigbo ChinemeremChigbo deleted the allow-letters-in-msp branch June 24, 2023 00:49
leogjhuang pushed a commit that referenced this pull request Jul 30, 2023
Doctor's MSP no longer only accepts numbers to be entered
leogjhuang added a commit that referenced this pull request Jul 30, 2023
* Allow numbers in MSP (#296)
* [Fix] Broken contact us link (#298)
* change nam and address spacing to absolute instead of floating (#300)
* Go to applicationProcessing instead of application (#301)
* update shopify version to undeprecated one (#302)
* Fix bash command for Windows (#299)
* Update shopify-buy in yarn.lock (#303)
* [Fix] No guardian on delete (#297)
* Update processing fee from $26 to $31 (#305)
* [Feature] Support search by permit ID on Permit Holders page (#307)
* Change pdf address spacing from 1.5 to 1.4 (#306)
leogjhuang added a commit that referenced this pull request Jul 31, 2023
* Allow numbers in MSP (#296)
* [Fix] Broken contact us link (#298)
* change nam and address spacing to absolute instead of floating (#300)
* Go to applicationProcessing instead of application (#301)
* update shopify version to undeprecated one (#302)
* Fix bash command for Windows (#299)
* Update shopify-buy in yarn.lock (#303)
* [Fix] No guardian on delete (#297)
* Update processing fee from $26 to $31 (#305)
* [Feature] Support search by permit ID on Permit Holders page (#307)
* Change pdf address spacing from 1.5 to 1.4 (#306)
* [Fix] Update form links to reflect new processing fee (#309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants