Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash command for Windows #299

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Conversation

ChinemeremChigbo
Copy link
Member

Notion ticket link

Ticket Name

Implementation description

  • Windows needs double slashes on this command to work appropriately. Could you double check that this still works on MacOS?

Notes

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting...single slashes have always worked for me 🤔

@leogjhuang could you please confirm if this is an issue on mac? Alternatively I think simply using bash might also work

@ChinemeremChigbo ChinemeremChigbo changed the title Add double slashes to README for windows Fix bash command for Windows Jul 8, 2023
@ChinemeremChigbo
Copy link
Member Author

Oh interesting...single slashes have always worked for me 🤔

@leogjhuang could you please confirm if this is an issue on mac? Alternatively I think simply using bash might also work

Changed to just use bash

@ChinemeremChigbo ChinemeremChigbo merged commit 160d45c into staging Jul 8, 2023
@ChinemeremChigbo ChinemeremChigbo deleted the update-readme-windows branch July 8, 2023 02:25
leogjhuang pushed a commit that referenced this pull request Jul 30, 2023
* add double slashes to README for windows

* change verify database command to use bash
leogjhuang added a commit that referenced this pull request Jul 30, 2023
* Allow numbers in MSP (#296)
* [Fix] Broken contact us link (#298)
* change nam and address spacing to absolute instead of floating (#300)
* Go to applicationProcessing instead of application (#301)
* update shopify version to undeprecated one (#302)
* Fix bash command for Windows (#299)
* Update shopify-buy in yarn.lock (#303)
* [Fix] No guardian on delete (#297)
* Update processing fee from $26 to $31 (#305)
* [Feature] Support search by permit ID on Permit Holders page (#307)
* Change pdf address spacing from 1.5 to 1.4 (#306)
leogjhuang added a commit that referenced this pull request Jul 31, 2023
* Allow numbers in MSP (#296)
* [Fix] Broken contact us link (#298)
* change nam and address spacing to absolute instead of floating (#300)
* Go to applicationProcessing instead of application (#301)
* update shopify version to undeprecated one (#302)
* Fix bash command for Windows (#299)
* Update shopify-buy in yarn.lock (#303)
* [Fix] No guardian on delete (#297)
* Update processing fee from $26 to $31 (#305)
* [Feature] Support search by permit ID on Permit Holders page (#307)
* Change pdf address spacing from 1.5 to 1.4 (#306)
* [Fix] Update form links to reflect new processing fee (#309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants