Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support search by permit ID on Permit Holders page #307

Merged
merged 2 commits into from
Jul 30, 2023

Conversation

sherryhli
Copy link
Member

Notion ticket link

Some users cannot be found by name search in Permit Holders...allow option to search by permit ID

Implementation description

Add additional permit ID filter to to applicant GraphQL query and expose on Permit Holders page

Testing:
permit-id-search

rcd=# select * from permits;
 rcd_permit_id |   type    | expiry_date | active | application_id | applicant_id |         created_at         |         updated_at
---------------+-----------+-------------+--------+----------------+--------------+----------------------------+----------------------------
             1 | PERMANENT | 2018-01-01  | f      |              2 |            2 | 2023-06-18 04:43:10.592+00 | 2023-06-18 04:43:10.592+00 
             3 | PERMANENT | 2023-07-17  | t      |              5 |            4 | 2023-06-18 04:43:10.699+00 | 2023-06-18 04:43:10.699+00 
             2 | PERMANENT | 2025-01-01  | f      |              3 |            3 | 2023-06-18 04:43:10.668+00 | 2023-06-18 04:43:10.668+00 
             4 | PERMANENT | 2025-01-01  | t      |              6 |            3 | 2023-06-18 09:27:02.475+00 | 2023-06-18 09:27:02.475+00 
(4 rows)

Notes

N/A

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@leogjhuang leogjhuang merged commit a837a72 into staging Jul 30, 2023
1 check passed
@leogjhuang leogjhuang deleted the sl/permit-id-search branch July 30, 2023 21:18
leogjhuang pushed a commit that referenced this pull request Jul 30, 2023
* [Feature] Support search by permit ID on Permit Holders page

* Revert accidental processingFee type change
leogjhuang added a commit that referenced this pull request Jul 30, 2023
* Allow numbers in MSP (#296)
* [Fix] Broken contact us link (#298)
* change nam and address spacing to absolute instead of floating (#300)
* Go to applicationProcessing instead of application (#301)
* update shopify version to undeprecated one (#302)
* Fix bash command for Windows (#299)
* Update shopify-buy in yarn.lock (#303)
* [Fix] No guardian on delete (#297)
* Update processing fee from $26 to $31 (#305)
* [Feature] Support search by permit ID on Permit Holders page (#307)
* Change pdf address spacing from 1.5 to 1.4 (#306)
leogjhuang added a commit that referenced this pull request Jul 31, 2023
* Allow numbers in MSP (#296)
* [Fix] Broken contact us link (#298)
* change nam and address spacing to absolute instead of floating (#300)
* Go to applicationProcessing instead of application (#301)
* update shopify version to undeprecated one (#302)
* Fix bash command for Windows (#299)
* Update shopify-buy in yarn.lock (#303)
* [Fix] No guardian on delete (#297)
* Update processing fee from $26 to $31 (#305)
* [Feature] Support search by permit ID on Permit Holders page (#307)
* Change pdf address spacing from 1.5 to 1.4 (#306)
* [Fix] Update form links to reflect new processing fee (#309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants