Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TN-3235 opt-out feature #4337

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Conversation

pbugni
Copy link
Collaborator

@pbugni pbugni commented Sep 6, 2023

Monster PR to implement the opt-out feature.
included front end changes from #4335
reused a migration (by altering the order defined within the migration files down_revision variable), and corrected as the previous sequential counts we not keeping up. (TN-3274)

includes implementations for:

@pep8speaks
Copy link

pep8speaks commented Sep 20, 2023

Hello @pbugni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-28 17:02:34 UTC

@pbugni pbugni force-pushed the feature/sequential-hard-triggers-fix branch from 4a53cde to 9f0b7b9 Compare October 4, 2023 23:49
@pbugni pbugni force-pushed the feature/sequential-hard-triggers-fix branch from 9f0b7b9 to c4f1acd Compare November 16, 2023 22:47
@pbugni pbugni force-pushed the feature/sequential-hard-triggers-fix branch from 97cc939 to 5f2645a Compare January 25, 2024 03:00
@pbugni pbugni force-pushed the feature/sequential-hard-triggers-fix branch 2 times, most recently from e993e23 to ae92158 Compare March 12, 2024 21:30
@pbugni pbugni force-pushed the feature/sequential-hard-triggers-fix branch from 9c29d3b to 7f4bb5e Compare March 20, 2024 16:40
@pbugni pbugni changed the title TN-3236 follow up fix TN-3236 opt-out feature Mar 22, 2024
@pbugni pbugni force-pushed the feature/sequential-hard-triggers-fix branch 2 times, most recently from 1474c1d to 92a501f Compare March 29, 2024 14:58
@pbugni pbugni changed the title TN-3236 opt-out feature TN-3235 opt-out feature Apr 23, 2024
@pbugni pbugni requested review from mcjustin and ivan-c April 23, 2024 18:47
achen2401 and others added 6 commits May 31, 2024 09:50
Address [TN-3242
story](https://movember.atlassian.net/browse/TN-3242?atlOrigin=eyJpIjoiOTE5YzI5Y2E1OTM5NDg4YWI4NTU2MWQ1NDljMTNkNzciLCJwIjoiaiJ9)

Changes:
- An opted out hard trigger now has one asterisk only – indicating
‘Support needed
- hide navigation buttons when there is only responses for one date
- de-bouncing window resize event call
- general report styling fixes

Example screenshot after fixes:


![Optout](https://github.com/uwcirg/truenth-portal/assets/12942714/be3775fb-1caf-4d67-9a33-207c74fb560b)

Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu>
…en fully opted-out of all hard-triggers for the visit.
https://movember.atlassian.net/browse/TN-3243 see [google
doc](https://docs.google.com/document/d/1bpTGL7cJA9AcAx8ww1D1cneyTFxIbnpdCNj6JnPGS6k/edit?disco=AAABPlHTByk)

- remove Dismiss button and close button (X at top right corner) (see
screenshot after changes)
- made Optout modal un-dismissable
- allow the user to continue (by clicking on the submit button) without
selecting any option

screenshot
![Screenshot 2024-06-25 at 3 51
03 PM](https://github.com/uwcirg/truenth-portal/assets/12942714/a17c1f6d-425d-4719-9231-5c47db21830c)

---------

Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu>
@mcjustin mcjustin self-requested a review June 28, 2024 16:43
@mcjustin
Copy link
Member

Sorry @ivan-c @pbugni , I approved this a short while ago but I'd misunderstood Anna - we do need to hold on releasing this until the week of July 8.

@pbugni pbugni merged commit 77e71a4 into develop Jul 2, 2024
2 checks passed
@pbugni pbugni deleted the feature/sequential-hard-triggers-fix branch July 2, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants