Bug in class.button-shortcode.php

[dghweb]

Hi,
There's a bug in file setup\class.button-shortcode.php on line 53

The parameters in the implode call are in the wrong order.

$class_string = implode($classes, ' ');
should be
$class_string = implode(' ', $classes);

This can cause a Fatal Error like this:

Fatal error: Uncaught TypeError: implode(): Argument #2 ($array) must be of type ?array, string given in /nfs/bronfs/uwfs/hw00/d59/globalwach/wordpress/wp-content/themes/uw-2014/setup/class.button-shortcode.php:53

Thanks,
Jasper Bleijs
Dept. of Global Health

[dghweb]

Hi @lcaple ,
Bumping this issue as UW-IT has upgraded PHP (per 4/16/2024) on the departmental webservers, and websites running the 2014 theme and using the button shortcode now throw a Fatal error.

Thanks,
Jasper Bleijs
Dept. of Global Health

[twentzel]

Adding on to this as well. http://www.globalmedicines.org/ Fatal error: Array and string offset access syntax with curly braces is no longer supported in /nfs/bronfs/uwfs/hw00/d96/globalrx/wordpress/wp-content/plugins/shortcodes-ultimate/includes/deprecated/functions.php on line 130 Regards, Tim Wentzel IT Manager, School of Pharmacy University of Washington, Box 357631, Seattle WA 98195 206-601-7007 mobile 206-221-1050 office ***@***.******@***.***> From: UW Dept of Global Health web admin ***@***.***> Date: Tuesday, April 16, 2024 at 2:20 PM To: uweb/uw-2014 ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [uweb/uw-2014] Bug in class.button-shortcode.php (Issue #192) Hi @lcaple<https://urldefense.com/v3/__https:/github.com/lcaple__;!!K-Hz7m0Vt54!jokhIf4YepLzI89tg-26Eu68fmZNtF1HLjLfL5Bn7Eaq4v6MUS8mWXwRQFA09Hgj7Fnu7yw07OVvW4tICtlM29kF$> , Bumping this issue as UW-IT has upgraded PHP (per 4/16/2024) on the departmental webservers, and websites running the 2014 theme and using the button shortcode now throw a Fatal error. Thanks, Jasper Bleijs Dept. of Global Health — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/uweb/uw-2014/issues/192*issuecomment-2059940073__;Iw!!K-Hz7m0Vt54!jokhIf4YepLzI89tg-26Eu68fmZNtF1HLjLfL5Bn7Eaq4v6MUS8mWXwRQFA09Hgj7Fnu7yw07OVvW4tICnENBaFw$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ABYQSJX5DPC7VTZDX4LARQTY5WIYTAVCNFSM6AAAAAAZQ6ED56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZHE2DAMBXGM__;!!K-Hz7m0Vt54!jokhIf4YepLzI89tg-26Eu68fmZNtF1HLjLfL5Bn7Eaq4v6MUS8mWXwRQFA09Hgj7Fnu7yw07OVvW4tICiT7MNFj$>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[lcaple]

Hi @lcaple , Bumping this issue as UW-IT has upgraded PHP (per 4/16/2024) on the departmental webservers, and websites running the 2014 theme and using the button shortcode now throw a Fatal error.

Thanks, Jasper Bleijs Dept. of Global Health

@dghweb
This was fixed back in July. . Pull down the latest version of the master branch for this fix.

[lcaple]

Adding on to this as well. http://www.globalmedicines.org/ Fatal error: Array and string offset access syntax with curly braces is no longer supported in /nfs/bronfs/uwfs/hw00/d96/globalrx/wordpress/wp-content/plugins/shortcodes-ultimate/includes/deprecated/functions.php on line 130

@twentzel , based on your error message this is an issue with the plugin shortcodes-ultimate and not the uw-2014 theme.

[dghweb]

Hi @lcaple , Bumping this issue as UW-IT has upgraded PHP (per 4/16/2024) on the departmental webservers, and websites running the 2014 theme and using the button shortcode now throw a Fatal error.
Thanks, Jasper Bleijs Dept. of Global Health
@dghweb
This was fixed back in July. . Pull down the latest version of the master branch for this fix.

Thank you. I missed that. My apologies.