Fix uwescience/myria-web#40 #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To work around #371, I added memory limits to channels. However, I made the per-channel and the global memory limits the same. This is clearly nuts: multiple channels can be active at the same time! In some plans with multiple fragments that produce data, I believe that one it is possible that one channel consumes all the memory and deadlocks the query execution because that channel's buffer won't be emptied until another channel on the same work is pushed. Fix this by getting rid of the global limit.
Random code cleanup, probably comes from automatic changes?
When using the PostgreSQL COPY method, make sure the correct number of tuples were actually inserted.
We want the appenders to see DEBUG messages; they won't actually log them unless the code *later* sets the level to DEBUG or below.
If possible, we should print the Java that causes the failure. Before this change: edu.washington.escience.myria.DbException: Error when evaluating expression edu.washington.escience.myria.expression.evaluate.ConstantEvaluator@48dd0a33 After: edu.washington.escience.myria.DbException: Error when evaluating expression (1/0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix uwescience/myria-web#40
Basically, add a column to the queries table to log the error message, if there was one, when the query executed.
Includes patches from #433 , so review after that one.