Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix queue resumption after modifier reduces counter to 0 #6

Merged
merged 1 commit into from
Oct 3, 2015

Conversation

qhool
Copy link
Contributor

@qhool qhool commented Oct 2, 2015

I was noticing an issue where a queue (used for periodic background processing) with a counter that is modified by the cpu regulator would 'freeze' after system cpu went high. My background processes would just stop until jobs was restarted. It turns out that the modifiers values would never reduces after going up, and that if all of my background processors were busy waiting on jobs:ask, nothing would cause jobs_server to allow() them. so I:

  • change merging of modifiers in jobs_sampler:calc_modifiers so that
    a new modifier that is lower can override an old higher modifier
  • when modifiers are set in jobs_server, check to see if any of the new
    modified counter values are higher than before; if so, revisit queues

  * change merging of modifiers in jobs_sampler:calc_modifiers so that
    a new modifier that is lower can override an old higher modifier
  * when modifiers are set in jobs_server, check to see if any of the new
    modified counter values are higher than before; if so, revisit queues
uwiger added a commit that referenced this pull request Oct 3, 2015
fix queue resumption after modifier reduces counter to 0
@uwiger uwiger merged commit 03799b6 into uwiger:master Oct 3, 2015
@uwiger
Copy link
Owner

uwiger commented Oct 3, 2015

Thanks. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants