Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace proxy #10521 ke #130

Merged
merged 23 commits into from
Mar 16, 2020
Merged

Replace proxy #10521 ke #130

merged 23 commits into from
Mar 16, 2020

Conversation

keichwa
Copy link
Contributor

@keichwa keichwa commented Mar 10, 2020

Clean up Replace Proxy description for SUMA and Uyuni.

Copy link

@mantel mantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor comments; apart from that it looks fine to me.

Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments. In general PR ,and the idea behind it, looks great.

modules/installation/pages/proxy-setup.adoc Outdated Show resolved Hide resolved
@keichwa
Copy link
Contributor Author

keichwa commented Mar 13, 2020

if you've time please recheck.
@Loquacity I need your review, too :)

Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current PR should work, but I strongly suggest deciding what to use in all places. Sometimes we have {productname} Proxy, sometimes {susemgrproxy} and sometimes only Proxy :-)

modules/installation/pages/proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
@keichwa
Copy link
Contributor Author

keichwa commented Mar 13, 2020 via email

@keichwa
Copy link
Contributor Author

keichwa commented Mar 14, 2020

Current PR should work, but I strongly suggest deciding what to use in all places. Sometimes we have {productname} Proxy, sometimes {susemgrproxy} and sometimes only Proxy :-)

The "problem" is that macro expansion does not always work everywhere... Nevertheless I'll now try to make better use of it and commit changes.

Copy link
Contributor

@Loquacity Loquacity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording stuff

modules/installation/pages/proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
modules/installation/pages/uyuni-proxy-setup.adoc Outdated Show resolved Hide resolved
keichwa and others added 10 commits March 16, 2020 06:41
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
keichwa and others added 5 commits March 16, 2020 07:06
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Sounds great, and is technically correct (IMO).

Co-Authored-By: Lana Brindley <lbrindley@suse.de>
@keichwa keichwa mentioned this pull request Mar 16, 2020
2 tasks
@keichwa keichwa merged commit a7846f0 into master Mar 16, 2020
@keichwa keichwa deleted the replace-proxy-#10521-ke branch March 16, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants