-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace proxy #10521 ke #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some minor comments; apart from that it looks fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments. In general PR ,and the idea behind it, looks great.
if you've time please recheck. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current PR should work, but I strongly suggest deciding what to use in all places. Sometimes we have {productname} Proxy
, sometimes {susemgrproxy}
and sometimes only Proxy
:-)
On 2020-03-13 17:41, Julio González Gil wrote:
juliogonzalez approved this pull request.
Current PR should work, but I strongly suggest deciding what to use in
all places. Sometimes we have `{productname} Proxy`, sometimes
`{susemgrproxy}` and sometimes only `Proxy` :-)
Yes, agreed. I can probably merge all this and then have it in one
file only again.
…--
Karl Eichwalder
|
The "problem" is that macro expansion does not always work everywhere... Nevertheless I'll now try to make better use of it and commit changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor wording stuff
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Sounds great, and is technically correct (IMO). Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Clean up Replace Proxy description for SUMA and Uyuni.