-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client registration #9333 ke #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootstrap script started
keichwa
requested review from
jcayouette,
mantel,
moio,
paususe and
Loquacity
December 18, 2019 12:42
In case you have time to take a look. |
mantel
reviewed
Dec 18, 2019
mantel
reviewed
Dec 18, 2019
mantel
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Loquacity
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor things, non-blocking. Nice work!
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
save part is misleading here. Per feedback.
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
delete "save" part. Per feedback.
…ct/uyuni-docs into client-registration-#9333-ke
keichwa
added a commit
that referenced
this pull request
Dec 23, 2019
* some cleanup actions and normalization * Web and CL done * use 3 files for 3 methods... * avoid single sentence paras SUSE/spacewalk#9333 Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close https://github.com/SUSE/spacewalk/issues/9333