Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client registration #9333 ke #36

Merged
merged 23 commits into from
Dec 23, 2019
Merged

Client registration #9333 ke #36

merged 23 commits into from
Dec 23, 2019

Conversation

keichwa
Copy link
Contributor

@keichwa keichwa commented Dec 18, 2019

@keichwa keichwa marked this pull request as ready for review December 18, 2019 13:34
@keichwa
Copy link
Contributor Author

keichwa commented Dec 18, 2019

In case you have time to take a look.
Mostly aligned now.

Copy link

@mantel mantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Loquacity Loquacity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor things, non-blocking. Nice work!

keichwa and others added 5 commits December 19, 2019 08:26
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
save part is misleading here. Per feedback.
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
keichwa and others added 2 commits December 19, 2019 08:33
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
delete "save" part. Per feedback.
@keichwa keichwa merged commit 8a748ca into master Dec 23, 2019
@keichwa keichwa deleted the client-registration-#9333-ke branch December 23, 2019 12:07
keichwa added a commit that referenced this pull request Dec 23, 2019
* some cleanup actions and normalization
* Web and CL done
* use 3 files for 3 methods...
* avoid single sentence paras

SUSE/spacewalk#9333
Co-Authored-By: Lana Brindley <lbrindley@suse.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants