Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce group activity management and grading #4073

Merged
merged 13 commits into from
May 25, 2024

Conversation

sjschlapbach
Copy link
Member

@sjschlapbach sjschlapbach commented Mar 21, 2024

Before merging, consider the following tasks:

  • Do not squash this development branch on merging, since it contains squashed PRs already!
  • Remove the "GroupActivityManagement" branch from the cypress-testing.yml file
  • Extend test suite with tests related to the group activity grading process
  • Extend documentation for group activity creation, student view and grading

Co-authored-by: sjschlapbach <julius.schlapbach@gmx.net>
Co-authored-by: Julius Schlapbach <80708107+sjschlapbach@users.noreply.github.com>
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

cypress bot commented Mar 21, 2024

Passing run #2232 ↗︎

0 37 0 0 Flakiness 0

Details:

Merge 3400fd5 into 525661c...
Project: klicker-uzh Commit: 61dd27cc72 ℹ️
Status: Passed Duration: 06:33 💡
Started: May 25, 2024 1:49 PM Ended: May 25, 2024 1:55 PM

Review all test suite changes for PR #4073 ↗︎

@coveralls
Copy link

coveralls commented Mar 21, 2024

Coverage Status

coverage: 68.493% (+0.4%) from 68.056%
when pulling 3400fd5 on GroupActivityManagement
into 525661c on v3.

@sjschlapbach sjschlapbach added the blocked Pull request is waiting for another pull request to be merged label Apr 24, 2024
@sjschlapbach sjschlapbach removed the blocked Pull request is waiting for another pull request to be merged label May 17, 2024
@sjschlapbach sjschlapbach marked this pull request as ready for review May 17, 2024 11:43
Copy link

sonarcloud bot commented May 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Member

@rschlaefli rschlaefli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjschlapbach sjschlapbach merged commit a0b0065 into v3 May 25, 2024
16 of 17 checks passed
@sjschlapbach sjschlapbach deleted the GroupActivityManagement branch May 25, 2024 15:26
Copy link

cypress bot commented May 25, 2024

Passing run #2233 ↗︎

0 37 0 0 Flakiness 0

Details:

feat: introduce group activity management and grading (#4073)
Project: klicker-uzh Commit: a0b00654ac
Status: Passed Duration: 06:36 💡
Started: May 25, 2024 3:34 PM Ended: May 25, 2024 3:40 PM

Review all test suite changes for PR #4073 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants