Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop notification - Should always show when browser is minimized #1

Closed
v1bh0r opened this issue Aug 22, 2012 · 5 comments
Closed
Milestone

Comments

@v1bh0r
Copy link
Owner

v1bh0r commented Aug 22, 2012

Steps to replicate the problem:

  1. User A logs in.
  2. User B logs in.
    (Both use Chrome with desktop notifications enabled.)
  3. A has B selected and B has A selected on the chat pane.
  4. A minimizes window.
  5. B sends a message to A.
  6. Notice no notification received.

Expected behavior:
Show notification.

@ghost ghost assigned v1bh0r Aug 22, 2012
@v1bh0r v1bh0r closed this as completed Aug 23, 2012
@v1bh0r
Copy link
Owner Author

v1bh0r commented Aug 23, 2012

I found that the builtin support for visibility detection does not work when browser is minimized but the tab was active... Would need to work-around somehow...

Also added a note for mozilla users about how to enable desktop notifications...

@shivam-mathur
Copy link
Collaborator

Hey!

Today I am unable to login to chantor..looks like its running on ur machine and since ur not in office, I guess no one would be able to login.

Just check on that as well.

From: Vibhor Mahajan [mailto:notifications@github.com]
Sent: Thursday, August 23, 2012 12:53 PM
To: vibhor86/chantor
Subject: Re: [chantor] Desktop notification - Should always show when browser is minimized (#1)

I found that the builtin support for visibility detection does not work when browser is minimized but the tab was active... Would need to work-around somehow...

Also added a note for mozilla users about how to enable desktop notifications...


Reply to this email directly or view it on GitHub #1 (comment) .

https://github.com/notifications/beacon/r8BThS0nMafX6_-EXttL33eSU6gqzZSYnF4AWM3-LLZNSmQ9aAyCk8ffsgV-KX24.gif

@shivam-mathur shivam-mathur reopened this Aug 23, 2012
@shivam-mathur
Copy link
Collaborator

Hi - in this I would wish to have to have the Chantor window come into focus when I click on desktop notification, if any user sends a message.
But, this is on very low priority.

@shivam-mathur
Copy link
Collaborator

Few more additions to enhancements (low priority):

  1. If user has not clicked on desktop notification, it should disappear after 5 seconds[Currently notification is not disappearing and is disturbing the work].
  2. After 5 seconds and disappearance of notification, the chat window should start blinking, if not in focus, notifying user that he/she has not viewed the message received.
  3. If any OR either of the user(s) are typing, it should be visible on the chat window, alike other instant messaging tools.

@v1bh0r
Copy link
Owner Author

v1bh0r commented Aug 23, 2012

Based on the original issue statement, the issue has been fixed...

I've also fixed the following:

in this I would wish to have to have the Chantor window come into focus when I click on desktop notification, if any user sends a message.

  1. If user has not clicked on desktop notification, it should disappear after 5 seconds[Currently notification is not disappearing and is disturbing the work].

Lets raise a separate enhancement request for:
2. After 5 seconds and disappearance of notification, the chat window should start blinking, if not in focus, notifying user that he/she has not viewed the message received.

I need to evaluate its feasibility...

I've already raised one for:
If any OR either of the user(s) are typing, it should be visible on the chat window, alike other instant messaging tools.

@v1bh0r v1bh0r closed this as completed Aug 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants