Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtls and sidh related bugs #249

Closed
advancedwebdeveloper opened this issue Oct 2, 2020 · 6 comments
Closed

xtls and sidh related bugs #249

advancedwebdeveloper opened this issue Oct 2, 2020 · 6 comments

Comments

@advancedwebdeveloper
Copy link

Hi.
I caught such bugs, related to two dependency packages:

~/go_projects/v2ray-core$ go test ./...

github.com/xtls/go/cpu

vendor/github.com/xtls/go/cpu/cpu_x86.s: Assembler messages:
vendor/github.com/xtls/go/cpu/cpu_x86.s:10: Error: no such instruction: text ·cpuid(SB),NOSPLIT,$0-24' vendor/github.com/xtls/go/cpu/cpu_x86.s:11: Error: junk (FP)' after expression
vendor/github.com/xtls/go/cpu/cpu_x86.s:11: Error: too many memory references for mov' vendor/github.com/xtls/go/cpu/cpu_x86.s:12: Error: junk (FP)' after expression
vendor/github.com/xtls/go/cpu/cpu_x86.s:12: Error: too many memory references for mov' vendor/github.com/xtls/go/cpu/cpu_x86.s:14: Error: too many memory references for mov'
vendor/github.com/xtls/go/cpu/cpu_x86.s:15: Error: too many memory references for mov' vendor/github.com/xtls/go/cpu/cpu_x86.s:16: Error: too many memory references for mov'
vendor/github.com/xtls/go/cpu/cpu_x86.s:17: Error: too many memory references for mov' vendor/github.com/xtls/go/cpu/cpu_x86.s:21: Error: no such instruction: text ·xgetbv(SB),NOSPLIT,$0-8'
vendor/github.com/xtls/go/cpu/cpu_x86.s:24: Error: too many memory references for mov' vendor/github.com/xtls/go/cpu/cpu_x86.s:25: Error: too many memory references for mov'

v2ray.com/core/external/github.com/cloudflare/sidh/internal/utils

external/github.com/cloudflare/sidh/internal/utils/cpuid_amd64.s: Assembler messages:
external/github.com/cloudflare/sidh/internal/utils/cpuid_amd64.s:5: Error: no such instruction: text ·cpuid(SB),NOSPLIT,$0-4' external/github.com/cloudflare/sidh/internal/utils/cpuid_amd64.s:6: Error: junk (FP)' after expression
external/github.com/cloudflare/sidh/internal/utils/cpuid_amd64.s:6: Error: too many memory references for mov' external/github.com/cloudflare/sidh/internal/utils/cpuid_amd64.s:7: Error: junk (FP)' after expression
external/github.com/cloudflare/sidh/internal/utils/cpuid_amd64.s:7: Error: too many memory references for mov' external/github.com/cloudflare/sidh/internal/utils/cpuid_amd64.s:9: Error: too many memory references for mov'
external/github.com/cloudflare/sidh/internal/utils/cpuid_amd64.s:10: Error: too many memory references for mov' external/github.com/cloudflare/sidh/internal/utils/cpuid_amd64.s:11: Error: too many memory references for mov'
external/github.com/cloudflare/sidh/internal/utils/cpuid_amd64.s:12: Error: too many memory references for `mov'

My compiler and environment is as follows:

$go env && go version
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/oceanfis81/.cache/go-build"
GOENV="/home/oceanfis81/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/oceanfis81/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/oceanfis81/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/oceanfish81/gollvm_dist"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/oceanfish81/gollvm_dist/tools"
GCCGO="/home/oceanfish81/gollvm_dist/bin/llvm-goc"
AR="ar"
CC="/usr/bin/clang"
CXX="/usr/bin/clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build835009193=/tmp/go-build -gno-record-gcc-switches -funwind-tables"
go version go1.15.2 gollvm LLVM 12.0.0git linux/amd64

CC @thanm @cherrymui

@RPRX
Copy link
Contributor

RPRX commented Oct 2, 2020

Go 1.15.2 的 internal/cpu 存在此问题吗?XTLS 的 go/cpu 是复制它的。

@advancedwebdeveloper
Copy link
Author

Go 1.15.2 的 internal/cpu 存在此问题吗?XTLS 的 go/cpu 是复制它的。

I am not understanding your language.
Please explain in English. Tnx

@RPRX
Copy link
Contributor

RPRX commented Oct 2, 2020

Is there the same problem with internal/cpu of Go 1.15.2? Cause go/cpu of XTLS was copied from it.

@advancedwebdeveloper
Copy link
Author

CC @mengwei-intel @finomeng @mdtoguchi @binghanintel @SunJianIntel @s1061123 @bergwolf @wuxyintel @teawater

I am using Intel Core2 Quad CPU Q9400

@RPRX
Copy link
Contributor

RPRX commented Oct 6, 2020

https://github.com/XTLS/Go now imports "golang.org/x/sys/cpu" in place of "github.com/xtls/go/cpu".

@RPRX RPRX closed this as completed Oct 6, 2020
@RPRX
Copy link
Contributor

RPRX commented Oct 6, 2020

https://github.com/XTLS/Go now imports "golang.org/x/sys/cpu" in place of "github.com/xtls/go/cpu".

Might have solved this problem in passing, but if not, there's nothing more I can do... Besides, sidh's problem is out of my control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants