Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic-go@v0.33.0 can not be built on go 1.21 #2701

Closed
bi4tms opened this issue Oct 2, 2023 · 3 comments · Fixed by #2721
Closed

quic-go@v0.33.0 can not be built on go 1.21 #2701

bi4tms opened this issue Oct 2, 2023 · 3 comments · Fixed by #2721

Comments

@bi4tms
Copy link

bi4tms commented Oct 2, 2023

The version of Go in Lean's openwrt has been updated to 1.21. As a result, v2ray can not been built correctly.
The log is shown below:
Building targets
github.com/quic-go/quic-go/internal/qtls

github.com/quic-go/quic-go/internal/qtls

../../../../../dl/go-mod-cache/github.com/quic-go/quic-go@v0.33.0/internal/qtls/go121.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.21 yet. For more details, please see https://github.com/quic-go/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.21 yet. F...) as int value in variable declaration

make[3]: *** [Makefile:44: /workdir/openwrt/build_dir/target-aarch64_generic_musl/v2ray-plugin-5.7.0/.built] Error 1
make[3]: Leaving directory '/workdir/openwrt/feeds/passwall_packages/v2ray-plugin'
time: package/feeds/passwall_packages/v2ray-plugin/compile#0.54#0.21#0.57
ERROR: package/feeds/passwall_packages/v2ray-plugin failed to build.
make[2]: *** [package/Makefile:116: package/feeds/passwall_packages/v2ray-plugin/compile] Error 1
make[2]: Leaving directory '/workdir/openwrt'
make[1]: *** [package/Makefile:110: /workdir/openwrt/staging_dir/target-aarch64_generic_musl/stamp/.package_compile] Error 2
make[1]: Leaving directory '/workdir/openwrt'
make: *** [/workdir/openwrt/include/toplevel.mk:231: world] Error 2

Please make quic-go compatible for go 1.21.
Thank you very much.

@bi4tms bi4tms changed the title 请求大佬适配go 1.21 quic-go@v0.33.0无法在go 1.21上编译,请求大佬适配 Oct 2, 2023
@bi4tms bi4tms changed the title quic-go@v0.33.0无法在go 1.21上编译,请求大佬适配 quic-go@v0.33.0 can not be built on go 1.21 Oct 2, 2023
@swxk521
Copy link

swxk521 commented Oct 3, 2023

+1

@ecrasy
Copy link

ecrasy commented Oct 4, 2023

很多openwrt的最新源碼都切換到Go 1.21了,
開發組是否考慮Release一個適配Go 1.21的版本?

@JimmyHuang454
Copy link
Contributor

JimmyHuang454 commented Oct 6, 2023

我做了一些实验性的 修改,给 QUIC 加上了Hysteria的拥塞算法,包括 BBR 和 Brutal;使用 Trojan + QUIC 网速将会有跟 Hysteria 一样的体验。

Hysteria 的 QUIC 是支持 Go 1.21 的,很方便就可以移植过来。 但是我做了很多的修改,包括更新了Protobuffer。不知道Contributor们怎么看 ... 如果愿意把Hysteria移植过来的话,我继续测试并调试一下BBR,再PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants