Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configuration file path to a more rational one #6

Merged
merged 5 commits into from
May 9, 2018
Merged

fix configuration file path to a more rational one #6

merged 5 commits into from
May 9, 2018

Conversation

timqi
Copy link
Contributor

@timqi timqi commented May 5, 2018

fix #5

@timqi
Copy link
Contributor Author

timqi commented May 7, 2018

seems no response when parse download url in checker.sh of travis-ci @Doublemine

@Doublemine
Copy link
Collaborator

Doublemine commented May 7, 2018

@timqi Thanks for PR, #5 point to the conf file location can be confusion. I think migrate conf file to new dir may be better choice. Such as /usr/local/etc/v2ray/config.json. And what's your suggestions?

timqi added 2 commits May 7, 2018 10:04
migrate conf file to /usr/local/etc/v2ray/config.json
@Doublemine
Copy link
Collaborator

Pls update readme.md as well, Thx.

@Doublemine
Copy link
Collaborator

@timqi When i test this pr, it will cause the error: Error: No such file or directory - v2ray/config.json. And i guess below code may cause some error:

etc.install "v2ray/config.json"

Had you tested it ?

@timqi
Copy link
Contributor Author

timqi commented May 9, 2018

Sorry for that I don't know how does etc.install work. It may cuz v2ray directory in etc path doesn't created before. Please help handling this at your ease.

@Doublemine
Copy link
Collaborator

Maybe i guess you can try this:

def install
    bin.install "v2ray"
    bin.install "v2ctl"
    bin.install "geoip.dat"
    bin.install "geosite.dat"
    (etc/"v2ray").mkpath
    etc.install "config.json" => "v2ray/config.json"
 end

And do some improve, i have not verified whether it is work, so you should test it on your mac env.

@Doublemine Doublemine merged commit e994e36 into v2ray:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i don't like the default config file location and default name
2 participants