[Keycloak] Fix generated passwords may have whitespaces when secret already exists #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 23, 2023 09:12
2 tasks
quaark
changed the title
quaark
added a commit
to quaark/helm-charts
that referenced
this pull request
Nov 14, 2023
…lready exists (v3io#1004) Co-authored-by: quaark <a.melnick@icloud.com>
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove irrelevant fields.]
[mychartname])Description
For the db password and master password, the password itself is generated once and stored in a secret. The secret isn't deleted and so if the app service restarts, the helm template gets the password from the existing secret. This resulted in a prefixed newline in the password. Added trimming to make sure this doesn't happen.