Add Update/Put item output #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavius
suggested changes
Feb 16, 2020
pkg/dataplane/http/context.go
Outdated
| @@ -1476,3 +1490,30 @@ func (c *context) stop(reason string, timeout *time.Duration) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| // parsing the mtime from a header of the form `__mtime_secs==1581605100 and __mtime_nsecs==498349956` | |||
| func parseMtimeHeader(response *v3io.Response) (int, int) { | |||
pkg/dataplane/http/context.go
Outdated
| updateItemInput.Path, | ||
| putItemFunctionName, | ||
| updateItemInput.Attributes, | ||
| updateItemInput.Condition, | ||
| putItemHeaders, | ||
| body) | ||
|
|
||
| mtimeSecs, mtimeNSecs := parseMtimeHeader(response) | ||
| output := &v3io.UpdateItemOutput{MtimeSecs: mtimeSecs, MtimeNSecs: mtimeNSecs} |
There was a problem hiding this comment.
Why do you need this "output" variable? Just set .Output to &v3io.UpdateItemOutput{...
Same as in the other place(s)
| if err != nil { | ||
| return 0, 0 | ||
| } | ||
| } |
pkg/dataplane/http/context.go
Outdated
| mtimeParts := strings.Split(expression, "==") | ||
| mtimeType := strings.TrimSpace(mtimeParts[0]) | ||
| if mtimeType == "__mtime_secs" { | ||
| mtimeSecsStr := strings.TrimSpace(mtimeParts[1]) |
There was a problem hiding this comment.
You're repeating the parse logic here. Please move to a small helper function that returns int, error
dinal
pushed a commit
to dinal/v3io-go
that referenced
this pull request
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an output for update and put item containing
mtime.