Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support standard set operations for permission data #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support standard set operations for permission data #9

wants to merge 1 commit into from

Conversation

VisenP
Copy link
Contributor

@VisenP VisenP commented Apr 12, 2023

This PR adds support for performing set operations on permissions such as union, intersection and difference. The main use case of this would be to compare different permission data.

Antony1060
Antony1060 reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@Antony1060 Antony1060 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be beneficial to use a more general terminology. E. g. joinPermissions instead of union and commonPermissions instead of intersection.

Antony1060
Antony1060 suggested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@Antony1060 Antony1060 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • rename as described in the comment above
  • update README
  • implement these in createPermissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antony1060 Antony1060 Antony1060 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VisenP @Antony1060