Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce redundancy & improve verification #18

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Reduce redundancy & improve verification #18

merged 3 commits into from
Nov 22, 2022

Conversation

xism4
Copy link
Contributor

@xism4 xism4 commented Oct 29, 2022

Points on this pull-request:

  • Prevent null connections from wasting API requests (on backends)
  • Avoid an unnecessary try/catch in the main thread (since if the metrics fail it is the firewall from where throw time out)
  • Using the ComponentBuilder instead of a textcomponent in each logger

Basicaly leads to run faster the software at all.

And I will explain a little more about the metrics, simply if it throws an exception is that it failed to send a request and it was because the firewall that this server has prevented it

@samfces samfces merged commit 8295b0f into v4Guard:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants