Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IO-1561] Mypy cleanup #652

Merged
merged 7 commits into from
Oct 3, 2023
Merged

[IO-1561] Mypy cleanup #652

merged 7 commits into from
Oct 3, 2023

Conversation

Nathanjp91
Copy link
Contributor

Problem

Lots of mypy typing errors exist within the old code

Solution

Begin cleanup of mypy typing issues

Changelog

Some existing mypy typing issues resolved

@linear
Copy link

linear bot commented Aug 24, 2023

IO-1561 Clean up linting and mypy errors

Work through the backlog of linter and typing errors

  • ruff
    • Found 2081 errors.
      [*] 188 potentially fixable with the --fix option.
  • mypy
    • Found 1096 errors in 78 files (checked 222 source files)

owencjones
owencjones suggested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@owencjones owencjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stuff to respond to before approval, but no outright issues to change.

We should address pytest tests without imports and and run blocks at the bottom globally soon too - not directly relevant to this

darwin/future/tests/meta/objects/test_datasetmeta.py Show resolved Hide resolved
darwin/torch/transforms.py Show resolved Hide resolved
darwin/torch/utils.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests/darwin/torch/dataset_test.py Show resolved Hide resolved
owencjones
owencjones approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@owencjones owencjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All resolved, thanks

@Nathanjp91 Nathanjp91 merged commit 9406963 into master Oct 3, 2023
9 checks passed
owencjones pushed a commit that referenced this pull request Oct 10, 2023
@Nathanjp91
[IO-1561] Mypy cleanup (#652)
445981d 
* mypy cleanup

* drop mypy settings that don't work

* np typing change

* remove overrides

* Literal fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owencjones owencjones owencjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nathanjp91 @owencjones