Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IO-1554][internal] Refactoring github actions #654

Closed
wants to merge 128 commits into from
Closed

[IO-1554][internal] Refactoring github actions #654

wants to merge 128 commits into from

Conversation

owencjones
Copy link
Contributor

Problem

Workflows have actions missing, updates that need doing, and could be clearer

Solution

Replace/refactor the workflows

Changelog

Added new bash scripts to run each action
Refactor flows to trigger bash scripts where applicable.

@linear
Copy link

linear bot commented Aug 25, 2023

IO-1554 Darwin-py CD pipeline

Either

  • create tag → deploy
  • weekly deploy
  • merge to master → deploy

Note:

  • linear tickets should be getting moved automatically (can use existing scripts)

Owen added 26 commits August 25, 2023 17:19
WIP
98671e0
Correction to scripts
21846b7
Script that confirms release needs doing
6668eac
Python versioning scripts WIP
bb8d0ec
Attempt at fix for changed files filter
f17b69f
Bash refactor
5a4aede
Update flows
413f600
Fixing Bash scripts and testing
5111954
Github token change
a338e80
Moved token to use github namespace
407e086
Output list of changed files
ba4591f
Testing passing around variables
ce703c2
Changing echo types
bd5873a
Trying a different approach
4cfcaad
Check gh cli version
891dec4
Fix for command wrapping
467bfd3
Setting step output
e389a70
Set env var
10cd78a
Different approach to passing vars
93fac8e
Format and lint should work now
5a79f49
Refactor of bash scripts
cce8fff
Re-enabled testing stage
ec1ddc5
Get absolute paths in bash scripts
7283cba
Ensure poetry is installed
611814f
Updated test script
b134b7c
Extract tests into own file for use elsewhere
d11a071
Owen added 28 commits September 5, 2023 15:18
Correct install deps reusable flow
52414ec
Change flows to pass variables correctly
92633fd
Return reusable to within tests
20ed111
Lock file was blocking tests
14e1479
Test fixes
be60008
Addition of a debug statement to sort context
e584cee
Jobs context
9b46d6c
Restructure linting and formatting
2a868c5
Get black and flake passing
9c1944f
Extracted formatting
47febf3
Permissions
41bc6d9
Linting and format jobs
b58d844
Use ruff instead of black
eac86d2
Bash syntax
e9af68c
Fix black
361b635
Changes to increment_version.py for CICD use
948cfca
Outline of all basic flows
84b15ce
End of PR task
60efa3c
Testing merge action
b60ca29
Typecheck fix
8148747
Job name change
39f8bb1
PR finish
3b9c49c
poetry install options
191eeb7
Deps change
79273f4
Switch to an action
3c9bda8
config entirely in ticks
d6ebc24
Taking mypy out of the mix for now-ticketed for return
681c6b1
Merge to master documentation job
aedd8fe
@owencjones
Copy link
Contributor Author

Closing to prevent runs costing minutes, now the PR action is tested.

@owencjones owencjones closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWilkie JBWilkie Awaiting requested review from JBWilkie JBWilkie will be requested when the pull request is marked ready for review JBWilkie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@owencjones