Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update outdated docs mentioning Octane #15

Closed
mathiasbynens opened this issue Oct 12, 2018 · 2 comments · Fixed by #37
Closed

Update outdated docs mentioning Octane #15

mathiasbynens opened this issue Oct 12, 2018 · 2 comments · Fixed by #37
Labels
docs

Comments

@mathiasbynens
Copy link
Member

https://v8.dev/docs/profile#profiling-web-applications
@drexpp
Copy link
Contributor

drexpp commented Oct 16, 2018

Hello Mathias if I want to help with this issue, should I setup my code and just modify those pages which include references to "Octane"?

Thanks!

@mathiasbynens
Copy link
Member Author

Hey @drexpp. Thanks for offering to help! In this particular case I think we could the linked page to point to https://v8.dev/blog/real-world-performance instead of Octane.

drexpp added a commit to drexpp/v8.dev that referenced this issue Oct 19, 2018
@drexpp
Change in the last paragraph mentioning "Octane"
044675b 
This change fixes v8#15, there are more documents which contain Octane mentions such as https://v8.dev/blog/real-world-performance so I believe there might be a chain of issues related to changing Octane refereces.
@drexpp drexpp mentioned this issue Oct 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change in the last paragraph mentioning "Octane" drexpp/v8.dev
2 participants
@mathiasbynens @drexpp