-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detection of reverted commits #47
base: master
Are you sure you want to change the base?
Conversation
A warning is added in the changelog on any commit reverted by another one. Whether a commit is a "revert commit" is determined by a regular expression for the commit message body.
Thanks, I've read the code, and understood what this does. A test would have been welcome, as a doc. But before working on that, I suggest you to wait, because I need to think about whether it is a good idea to add this as you did. I was thinking that this type of modification should be possible via the filters (it is not currently feasible because we don't have access to the full commit object in filters, and we probably could). This would allow your whole PR code to be a single filter function, with the addition of being very easily configurable, or removed... BTW, forcing the unrolling of the |
You are right; I see that GitRepos.log() guarantees reverse chronological order. I wasn't aware of that before, and I will eliminate the log unrolling. I also think that a generic solution like filters is preferrable. My gut feeling is that more specific extensions are about to come. |
This avoids storing all commits in a list, as commit 2f8dd4 did. It relies on log() returning commits in reverse chronological order.
The repository fork reason is added.
ce9843a
to
7c6b7f1
Compare
fedee4e
to
b1cb854
Compare
b8bd6c6
to
f53d1cc
Compare
The changelog may contain commits that have been reverted.
A warning line is added on each of these commits.
Why ? Before we publish, one team member will revise and rework the changelog.
The warning aids him to not accidentially advertise a reverted feature.