-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to have this encode as configured #86
base: master
Are you sure you want to change the base?
Conversation
Ok thx, can you tell us your platform (windows ? linux ? macosx ?, your python version ?) |
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 88.42% 88.45% +0.02%
==========================================
Files 2 2
Lines 838 840 +2
Branches 168 169 +1
==========================================
+ Hits 741 743 +2
Misses 58 58
Partials 39 39
Continue to review full report at Codecov.
|
So it was python2.7 on OSX. I've just updated the code to be python version conditional, though that doesn't seem ideal.
I'll also update this PR, with comments in the project's style, as well a squash them down into one commit, when it looks good |
Was getting some stack traces when this was writing out UTF-8 git commit log content. Made this change locally to address.
Was getting some stack traces when this was writing out UTF-8 git commit log content. Made this change locally to address.