Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin the version of the WebComponents polyfills to the one which works (fix #107) #110

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

vlukashov
Copy link
Contributor

@vlukashov vlukashov commented Jul 20, 2017

The latest version of the WebComponents polyfills has a bug which makes vaadin-board unusable in Firefox and IE11. Until the bug is fixed, the version of webcomponentsjs polyfills used to build the the precompiled vaadin board package has to be pinned (to avoid using the latest). The version of polymer is pinned as well but only because the latest version of polymer requires the latest version of webcomponentsjs.

WebComponents polyfills issue: webcomponents/webcomponentsjs#811


This change is Reviewable

The latest version of the WebComponents polyfills has a bug which makes vaadin-board unusable in Firefox and IE11. Until the bug is fixed, the version of webcomponentsjs polyfills used to build the the precompiled vaadin board package has to be pinned (to avoid using the latest). The version of polymer is pinned as well but only because the latest version of polymer requires the latest version of webcomponentsjs.

 WebComponents polyfills issue: webcomponents/webcomponentsjs#811
@alvarezguille
Copy link
Member

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@alvarezguille alvarezguille merged commit 6af1ea4 into master Jul 20, 2017
@alvarezguille alvarezguille deleted the fix/107-board-broken-in-ie11 branch July 20, 2017 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants