Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent renaming VaadinUI to CDIUI is misleading #16

Closed
AdamBien opened this issue Apr 29, 2013 · 6 comments
Closed

Recent renaming VaadinUI to CDIUI is misleading #16

AdamBien opened this issue Apr 29, 2013 · 6 comments

Comments

@AdamBien
Copy link
Contributor

The name CDIUI and CDIView (prefix CDI) is misleading. The class it not a CDIView (CDI does not have any views). VaadinUI was better, but longer. I would rename it back to VaadinUI or just straight to UI.

@jangalinski
Copy link

When I use "extends UI" and "@ui" on my class, I cannot import both (so I would have to use FQN), so your last option would confuse me.
And since UI already is the Vaadin core component, annotating it with "VaadinUI" seems redundant. So although five capital letters in a row look strange ... as a user, I liked @CDIUI ... it annotates my vaadin UI with a cdi specific extension.

@AdamBien
Copy link
Contributor Author

You are right. This was the reason, why we started with VaadinUI. Five capital letters do look strange :-). IMHO the annotation just marks a class as being a Vaadin UI. If the majority of CDI-extesion users prefers @CDIUI over @VaadinUI I'm perfectly fine with that.

@jojule
Copy link

jojule commented Apr 29, 2013

Those were the exact reasons for the change.

On Mon, Apr 29, 2013 at 10:54 AM, Jan Galinski notifications@github.comwrote:

When I use "extends UI" and "@ui https://github.com/UI" on my class, I
cannot import both (so I would have to use FQN), so your last option would
confuse me.
And since UI already is the Vaadin core component, annotating it with
"VaadinUI" seems redundant. So although five capital letters in a row look
strange ... as a user, I liked @CDIUI ... it annotates my vaadin UI with a
cdi specific extension.


Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-17153865
.

Dr. Joonas Lehtinen, CEO
Vaadin - http://vaadin.com/

FI: +358-40-5035001, US: (415) 513-0739, Skype: joonaslehtinen
Office: Vaadin Oy, Ruukinkatu 2-4, 20540, Turku, Finland
Twitter: https://twitter.com/joonaslehtinen
LinkedIn: http://fi.linkedin.com/in/joonaslehtinen

@AdamBien
Copy link
Contributor Author

IMHO CDIUI is misleading, because we get integration with the whole JavaEE and not only CDI. It is more than likely, that you will inject an EJB into the UI and CDI managed beans into the EJB. JavaEEUI would be more consistent, but I don't like the name either and Java is trademarked.

@VaadinUI is redundant, but logical--you recognize immediately, that the annotation belongs to Vaadin. CDIUI looks like an annotation coming from CDI. It might be confusing for JavaEE + Vaadin beginners. I would just prefix everything consistently with Vaadin.

Alternative: we could also rename CDIUI after the responsibilities like: DiscoverableUI. It means: a view that does not have to be registered somewhere. Like @startup in EJB. Or ScopedUI -- UI participated in a scope or just: @tab (browser tab)

@jojule
Copy link

jojule commented Apr 29, 2013

Neither CDIUI or any of the proposed names are good. Unfortunately I do not have a better alternative. A word describing what happens for UI might be the best. Something like @attached or @Served

Dr. Joonas Lehtinen, CEO
Vaadin - http://vaadin.com/

FI: +358-40-5035001, US: (415) 513-0739, Skype: joonaslehtinen
Office: Vaadin Oy, Ruukinkatu 2-4, 20540, Turku, Finland
Twitter: https://twitter.com/joonaslehtinen
LinkedIn: http://fi.linkedin.com/in/joonaslehtinen

On Mon, Apr 29, 2013 at 11:12 PM, Adam Bien notifications@github.com
wrote:

IMHO CDIUI is misleading, because we get integration with the whole JavaEE and not only CDI. It is more than likely, that you will inject an EJB into the UI and CDI managed beans into the EJB. JavaEEUI would be more consistent, but I don't like the name either and Java is trademarked.
@VaadinUI is redundant, but logical--you recognize immediately, that the annotation belongs to Vaadin. CDIUI looks like an annotation coming from CDI. It might be confusing for JavaEE + Vaadin beginners. I would just prefix everything consistently with Vaadin.

Alternative: we could also rename CDIUI after the responsibilities like: DiscoverableUI. It means: a view that does not have to be registered somewhere. Like @startup in EJB. Or ScopedUI -- UI participated in a scope or just: @tab (browser tab)

Reply to this email directly or view it on GitHub:
#16 (comment)

@Artur-
Copy link
Member

Artur- commented Aug 15, 2013

All CDI issues in GitHub have been moved to http://dev.vaadin.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants