-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reimplement @RouteScoped to keep beans for PreserveOnRefresh #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaadin-cdi/src/main/java/com/vaadin/cdi/context/RouteScopedContext.java
Outdated
Show resolved
Hide resolved
- presere beans for PreserveOnRefresh views - reimplement absent RouteScopeOwner semantic - do not allow to use (route) scope when it's not available fixes #369
denis-anisimov
force-pushed
the
369-route-scoped
branch
from
June 4, 2021 06:12
73ae2d2
to
d90a680
Compare
pleku
suggested changes
Jun 7, 2021
vaadin-cdi/src/main/java/com/vaadin/cdi/context/RouteScopedContext.java
Outdated
Show resolved
Hide resolved
pleku
approved these changes
Jun 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge #371 before this though so we get a correct snapshot version
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #369
Description
Please list all relevant dependencies in this section and provide summary of the change, motivation and context.
Fixes # (issue)
Type of change
Checklist
Additional for
Feature
type of change