Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reimplement @RouteScoped to keep beans for PreserveOnRefresh #370

Merged
merged 4 commits into from
Jun 7, 2021
Merged

feat: reimplement @RouteScoped to keep beans for PreserveOnRefresh #370

merged 4 commits into from
Jun 7, 2021

Conversation

denis-anisimov
Copy link

@denis-anisimov denis-anisimov commented Jun 4, 2021 •
edited

  • presere beans for PreserveOnRefresh views
  • reimplement absent RouteScopeOwner semantic
  • do not allow to use (route) scope when it's not available

fixes #369

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@denis-anisimov denis-anisimov added this to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Jun 4, 2021
feat: reimplement @RouteScoped to keep beans for PreserveOnRefresh
d90a680 
- presere beans for PreserveOnRefresh views
- reimplement absent RouteScopeOwner semantic
- do not allow to use (route) scope when it's not available

fixes #369
@pleku pleku self-requested a review June 7, 2021 06:03
pleku
pleku approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@pleku pleku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge #371 before this though so we get a correct snapshot version

@denis-anisimov denis-anisimov merged commit c4c6d37 into master Jun 7, 2021
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Jun 7, 2021
@denis-anisimov denis-anisimov deleted the 369-route-scoped branch June 7, 2021 14:28
@mcollovati mcollovati mentioned this pull request Sep 14, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleku pleku pleku approved these changes

@sonatype-lift sonatype-lift[bot] sonatype-lift left review comments

Assignees
No one assigned
Labels
None yet
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align @RouteScoped implementation with @RouteScope impl for Spring add-on
2 participants
@denis-anisimov @pleku