Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove deprecated Renderer API #4471

Merged
merged 4 commits into from
Jan 2, 2023
Merged

refactor!: remove deprecated Renderer API #4471

merged 4 commits into from
Jan 2, 2023

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Jan 2, 2023 •
edited
Loading

Description

Follow-up for #4224

Removes deprecated API from the Renderer class.

Type of change

  • Refactoring

@tomivirkki tomivirkki marked this pull request as draft January 2, 2023 10:48
@tomivirkki tomivirkki marked this pull request as ready for review January 2, 2023 13:46
@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 51 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

DiegoCardoso
DiegoCardoso approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@web-padawan web-padawan merged commit a6c0ea1 into master Jan 2, 2023
@web-padawan web-padawan deleted the refactor/remove-deprecated-renderer-api branch January 2, 2023 18:51
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha8 and is also targeting the upcoming stable 24.0.0 version.

@javier-godoy javier-godoy mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

Assignees
No one assigned
Labels
prerelease version for Vaadin 24.0.0 Released with Vaadin 24.0.0.alpha8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomivirkki @vaadin-bot @DiegoCardoso @web-padawan