fix: properly initialize HTML value when using RTE in dialog #6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
approved these changes
Sep 17, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
pushed a commit
that referenced
this pull request
Sep 17, 2024
vursen
pushed a commit
that referenced
this pull request
Sep 17, 2024
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delays setting HTML value into
beforeClientResponseto fix conversion of the HTML value into the Delta value.I have not fully identified the root cause, but there seems to be some timing issue when using RTE in a dialog that is auto-added to the UI (which also uses
beforeClientResponse). The regression was introduced with #4538, before that RTE was also usingbeforeClientResponseto set the HTML value. Besides, with the new behavior thedangerouslySetHtmlValueJS call is only run once instead of 3 times as it is now.Fixes #6636