Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse the reversed error message #6290

Closed
Artur- opened this issue Aug 20, 2019 · 3 comments
Closed

Reverse the reversed error message #6290

Artur- opened this issue Aug 20, 2019 · 3 comments
Labels
DX enhancement Good First Issue Help wanted
Milestone
2.0.10

Comments

@Artur-
Copy link
Member

Artur- commented Aug 20, 2019

If a frontend file is not find, then the following error is printed

  Failed to resolve the following files either:
   · in the `/frontend` sources folder
   · or as a `META-INF/resources/frontend` resource in some JAR.
      - ./grid-form.js

The most important piece of information should come first, i.e. ./grid-form.js was the file that was not found. Now you need to parse though all paths (which are most of the time irrelevant) before finding the file name, which is relevant. A better version would be e.g.

Failed to find `./grid-form.js`.

Locations searched were:
- `/frontend` in this project
- `META-INF/resources/frontend` in included JARs
@project-bot project-bot bot added this to Inbox - needs triage in OLD Vaadin Flow ongoing work (Vaadin 10+) Aug 20, 2019
@pleku pleku removed this from Inbox - needs triage in OLD Vaadin Flow ongoing work (Vaadin 10+) Aug 27, 2019
@Fibii
Copy link

Fibii commented Aug 28, 2019

can you put more information about how to contribute? maybe start with which file is responsible for this exception/error...

@pleku
Copy link
Contributor

pleku commented Aug 29, 2019

Hi @Fibii, you should setup the project following the readme instructions https://github.com/vaadin/flow#setting-up-eclipse-to-develop-flow

Searching from the sources, I could locate the error message to:
https://github.com/vaadin/flow/blob/master/flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskUpdateImports.java#L268

@MichaelWMerritt
Copy link
Contributor

@pleku, I'd like to handle this if @Fibii is not working on it.

MichaelWMerritt added a commit to MichaelWMerritt/flow that referenced this issue Aug 31, 2019
@MichaelWMerritt
Reverse the reversed error message vaadin#6290
59991b8 
Shows list of files not found first before listing the directories searched.
At the same time I referenced the constant for RESOURCES_FRONTEND_DEFAULT
instead of hard-coding that path.

Added two new test cases to cover single- and multi-file exception messages.
@MichaelWMerritt MichaelWMerritt mentioned this issue Aug 31, 2019
Merged
joheriks pushed a commit that referenced this issue Sep 3, 2019
@MichaelWMerritt
Reverse the reversed error message #6290 (#6368)
cb33636 
Shows list of files not found first before listing the directories searched.
At the same time I referenced the constant for RESOURCES_FRONTEND_DEFAULT
instead of hard-coding that path.

Added two new test cases to cover single- and multi-file exception messages.

Fixes #6290
@joheriks joheriks added this to the 2.0.10 milestone Sep 3, 2019
joheriks pushed a commit that referenced this issue Sep 3, 2019
@MichaelWMerritt
Reverse the reversed error message #6290 (#6368)
b139db2 
Shows list of files not found first before listing the directories searched.
At the same time I referenced the constant for RESOURCES_FRONTEND_DEFAULT
instead of hard-coding that path.

Added two new test cases to cover single- and multi-file exception messages.

Fixes #6290
joheriks pushed a commit that referenced this issue Sep 3, 2019
Picks for 2.0.10 (#6383)
ef1b605 
* Check webpack config and build-info depending on compatibility mode (#6343)

Fixes #6233

* Reverse the reversed error message #6290 (#6368)

Shows list of files not found first before listing the directories searched.
At the same time I referenced the constant for RESOURCES_FRONTEND_DEFAULT
instead of hard-coding that path.

Added two new test cases to cover single- and multi-file exception messages.

Fixes #6290

* Consider folders in the classpath when copying resources (#6246) (#6379)

#6306

* Update RoutePrefix to fix Javadoc typo (#6350)

* Update RoutePrefix to fix JavaDoc typo
* Update Route to fix Javadoc typo

* Preserve JavaScript annotations order (#6371)

* Preserve JavaScript annotations order

Fixes #6198

* Improve test code

* Revert method rename and visibility modification to maintain API compatibility
joheriks pushed a commit that referenced this issue Sep 3, 2019
@MichaelWMerritt
Reverse the reversed error message #6290 (#6368)
42813d1 
Shows list of files not found first before listing the directories searched.
At the same time I referenced the constant for RESOURCES_FRONTEND_DEFAULT
instead of hard-coding that path.

Added two new test cases to cover single- and multi-file exception messages.

Fixes #6290
joheriks pushed a commit that referenced this issue Sep 3, 2019
@MichaelWMerritt
Reverse the reversed error message #6290 (#6368)
af364ca 
Shows list of files not found first before listing the directories searched.
At the same time I referenced the constant for RESOURCES_FRONTEND_DEFAULT
instead of hard-coding that path.

Added two new test cases to cover single- and multi-file exception messages.

Fixes #6290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX enhancement Good First Issue Help wanted
Projects
None yet
Milestone
2.0.10
Development

No branches or pull requests
6 participants
@Artur- @pleku @caalador @joheriks @MichaelWMerritt @Fibii