Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend resources import with multimodule Maven projects #6306

Closed
flefebure opened this issue Aug 22, 2019 · 1 comment
Closed

Frontend resources import with multimodule Maven projects #6306

flefebure opened this issue Aug 22, 2019 · 1 comment
Labels
Milestone

Comments

@flefebure
Copy link

flefebure commented Aug 22, 2019

We are migrating a Vaadin7/SpringBoot multimodule Gradle project to Flow 14.
Waiting for a compatible Gradle Plugin, I'm training with a Maven Multimodule project.

The subject is the handling of frontend resources (js, css..) located in modules.

For training, I tried to convert https://github.com/vaadin/flow-spring-examples to a multimodule layout
The result is https://github.com/flefebure/flow-spring-examples

The results of my tests are :
In production mode :

  • I needed to put the resources both in ui-module/src/main/resources/ and ui-module/src/main/resources/META-INF/resources/frontend

  • I needed to change the import from @jsmodule("./src/example-template.js") to @jsmodule("src/example-template.js")

  • Then I can build and run successfully the bootJar with

mvn -PproductionMode clean package
java  ui-bootstrap/target/ui-bootstrap-1.0.0-SNAPSHOT.jar

In dev-mode : (main-class run in intellij Idea)

Are there work in progress at this level ?

Hope this helps

@pleku
Copy link
Contributor

pleku commented Sep 3, 2019

Fixed by #6379

@pleku pleku closed this as completed Sep 3, 2019
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from P1 - High priority to Closed - pending release Sep 3, 2019
@pleku pleku added this to the 2.0.10 milestone Sep 3, 2019
joheriks pushed a commit that referenced this issue Sep 3, 2019
* Check webpack config and build-info depending on compatibility mode (#6343)

Fixes #6233

* Reverse the reversed error message #6290 (#6368)

Shows list of files not found first before listing the directories searched.
At the same time I referenced the constant for RESOURCES_FRONTEND_DEFAULT
instead of hard-coding that path.

Added two new test cases to cover single- and multi-file exception messages.

Fixes #6290

* Consider folders in the classpath when copying resources (#6246) (#6379)

#6306

* Update RoutePrefix to fix Javadoc typo (#6350)

* Update RoutePrefix to fix JavaDoc typo
* Update Route to fix Javadoc typo

* Preserve JavaScript annotations order (#6371)

* Preserve JavaScript annotations order

Fixes #6198

* Improve test code

* Revert method rename and visibility modification to maintain API compatibility
@mehdi-vaadin mehdi-vaadin moved this from Closed - pending release to Closed - released in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants