CCDM: Consider folders in the classpath when copying resources (#6246) #6379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained (waiting on @denis-anisimov and @pleku)
joheriks
pushed a commit
that referenced
this pull request
Sep 3, 2019
joheriks
pushed a commit
that referenced
this pull request
Sep 3, 2019
joheriks
pushed a commit
that referenced
this pull request
Sep 3, 2019
* Check webpack config and build-info depending on compatibility mode (#6343) Fixes #6233 * Reverse the reversed error message #6290 (#6368) Shows list of files not found first before listing the directories searched. At the same time I referenced the constant for RESOURCES_FRONTEND_DEFAULT instead of hard-coding that path. Added two new test cases to cover single- and multi-file exception messages. Fixes #6290 * Consider folders in the classpath when copying resources (#6246) (#6379) #6306 * Update RoutePrefix to fix Javadoc typo (#6350) * Update RoutePrefix to fix JavaDoc typo * Update Route to fix Javadoc typo * Preserve JavaScript annotations order (#6371) * Preserve JavaScript annotations order Fixes #6198 * Improve test code * Revert method rename and visibility modification to maintain API compatibility
joheriks
pushed a commit
that referenced
this pull request
Sep 3, 2019
joheriks
pushed a commit
that referenced
this pull request
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from ccdm branch
This change is