Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid processing value change event due writing back of converted value #12183

Merged
merged 8 commits into from
Nov 11, 2021

Conversation

TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Oct 27, 2021

This is both a optimization by skipping duplicate validation round and avoids ConcurrentModificationExpectation being thrown certain corner cases.

Cherry pick from: vaadin/framework#12360

@TatuLund TatuLund changed the title Add unit test for testing duplicate validation rounds fix: Avoid processing value change event due writing back of converted value Oct 27, 2021
@anssit anssit removed the request for review from mshabarov November 10, 2021 14:26
Copy link
Contributor

@anssit anssit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test based on review comments.

Artur-
Artur- previously approved these changes Nov 11, 2021
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Nov 11, 2021
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 8 issues

  1. MAJOR Binder.java#L945: Rename "binding" which hides the field declared at line 899. rule
  2. MAJOR Binder.java#L1018: Rename "binding" which hides the field declared at line 899. rule
  3. MINOR Binder.java#L246: "public" is redundant in this context. rule
  4. MINOR Binder.java#L253: "public" is redundant in this context. rule
  5. MINOR Binder.java#L1957: Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. rule
  6. MINOR Binder.java#L2029: Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. rule
  7. INFO Binder.java#L2812: Complete the task associated to this TODO comment. rule
  8. INFO Binder.java#L2826: Complete the task associated to this TODO comment. rule

@Artur- Artur- merged commit 57bfc5e into master Nov 11, 2021
@Artur- Artur- deleted the cp-v8-12360 branch November 11, 2021 11:25
@vaadin-bot
Copy link
Collaborator

Hi @TatuLund and @Artur-, when i performed cherry-pick to this commit to 8.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 57bfc5e
error: could not apply 57bfc5e... fix: Avoid processing value change event due writing back of converted value (#12183)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

Hi @TatuLund and @Artur-, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 57bfc5e
error: could not apply 57bfc5e... fix: Avoid processing value change event due writing back of converted value (#12183)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@anssit
Copy link
Contributor

anssit commented Nov 11, 2021

Updated the label to 0.0.1 from 1.0.0. The bot was mistaken because of other changes in target branch.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

anssit pushed a commit that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants