Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid processing value change event due writing back of converted value #12360

Merged
merged 6 commits into from
Aug 6, 2021

Conversation

TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Aug 6, 2021

This is both a optimization by skipping duplicate validation round and avoids ConcurrentModificationExpectation being thrown certain corner cases.

Fixes: #12356

…d value

This is both a optimization by skipping duplicate validation round and avoids ConcurrentModificationExpectation being thrown certain corner cases.
@TatuLund TatuLund added this to the 8.13.3 milestone Aug 6, 2021
@Ansku Ansku merged commit b379bb8 into master Aug 6, 2021
@Ansku Ansku deleted the fix12356 branch August 6, 2021 15:30
@ladislavlencucha
Copy link

Such a simple solution for such a huge issue. Thanks! You made my day by fixing it so fast!
Any news when 8.13.3 is going to be released?

Thanks again!

@Ansku
Copy link
Member

Ansku commented Aug 6, 2021

Our releases team has already left for the weekend so can't confirm the schedule yet, but the fix is already in 8.14-SNAPSHOT.

Ansku pushed a commit that referenced this pull request Aug 9, 2021
…d value (#12360)

This is both a optimization by skipping duplicate validation round and avoids ConcurrentModificationExpectation being thrown certain corner cases.
Ansku pushed a commit that referenced this pull request Aug 9, 2021
(#12360)

This is both a optimization by skipping duplicate validation round and
avoids ConcurrentModificationExpectation being thrown certain corner
cases.
@Ansku
Copy link
Member

Ansku commented Aug 9, 2021

There are some other releases that we need to get out first, but currently looks like 8.13.3 could happen towards the end of the week if everything goes well.

Ansku added a commit that referenced this pull request Aug 9, 2021
…2367)

(#12360)

This is both a optimization by skipping duplicate validation round and
avoids ConcurrentModificationExpectation being thrown certain corner
cases.

Co-authored-by: Tatu Lund <tatu@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two fields with converter in one binder cause ConcurrentModificationException
3 participants