Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid: New line with required TextFields is not validated properly #10891

Closed
mirkoliver opened this issue May 7, 2018 · 2 comments
Closed

Grid: New line with required TextFields is not validated properly #10891

mirkoliver opened this issue May 7, 2018 · 2 comments
Labels

Comments

@mirkoliver
Copy link

mirkoliver commented May 7, 2018

My Grid with TextFields as editors has some required columns. When editing and leaving required fields empty, it is not possible to leave the Editor - a validation error message is shown. This is the normal behaviour.

But after adding a new line in Grid via

itemList.add(new MyBean());
grid.getDataProvider().refreshAll();

and editing one or more field but also leaving one or more required fields empty, the Editor can be left without any error message.

Only if first I add to every field a value, leave the field (remaining in Editor) and then navigate back to one or more required fields and delete their values, the Editor cannot be left any more and the validation error messages occur.

Does this have to do something with these Vaadin github issues?

#9000

#10422

I'm using Vaadin Framework version 8.4.1.

@mirkoliver mirkoliver changed the title Grid: A new line with required TextFields is not validated properly Grid: New line with required TextFields is not validated properly May 7, 2018
@stale
Copy link

stale bot commented Oct 4, 2018

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Oct 4, 2018
@mlopezFC
Copy link
Contributor

mlopezFC commented May 5, 2020

Hi! ... I did some tests, and I see that is behaving correctly according to Tatu's explanation about this design decision.

@stale stale bot removed the Stale Stale bot label label May 5, 2020
@TatuLund TatuLund closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants