Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Going from a serverLayout view to non layout view does a failing server roundtrip #2726

Closed
caalador opened this issue Sep 11, 2024 · 1 comment · Fixed by vaadin/flow#19945
Closed

Going from a serverLayout view to non layout view does a failing server roundtrip #2726

caalador opened this issue Sep 11, 2024 · 1 comment · Fixed by vaadin/flow#19945
Assignees
@caalador
Labels
bug Something isn't working hilla Issues related to Hilla Released with Vaadin 24.4.13

Comments

@caalador
Copy link
Contributor

Describe the bug

When having hilla views where some use a server layout and some do not moving from a view with a server layout to a view without a server layout we still get a call to the server which generates an exception No layout for client path '' even if the path navigated to was for instance home

Expected-behavior

No call is made to the server for a layout when navigating to a client view without layout.

Reproduction

  • Using an application with hilla views add a Flow layout for one view and not for another.
  • Navigate to the view with the server layout
  • now navigate with a link to the other view
  • check server log for exception

System Info

Vaadin 24.5-SNAPSHOT
@caalador caalador added bug Something isn't working hilla Issues related to Hilla labels Sep 11, 2024
@caalador caalador self-assigned this Sep 12, 2024
caalador added a commit to vaadin/flow that referenced this issue Sep 12, 2024
@caalador
fix: Evaluate target not active
52f8484 
For deciding what action to
take we should evaluate where
we are going and not the current
active path.

Fixes vaadin/hilla#2726
@caalador caalador mentioned this issue Sep 12, 2024
Merged
vaadin-bot pushed a commit to vaadin/flow that referenced this issue Sep 13, 2024
@caalador @vaadin-bot
fix: Evaluate target not active (#19945)
68fb73f 
For deciding what action to
take we should evaluate where
we are going and not the current
active path.

Fixes vaadin/hilla#2726
vaadin-bot added a commit to vaadin/flow that referenced this issue Sep 13, 2024
@vaadin-bot @caalador
fix: Evaluate target not active (#19945) (#19950)
d48d95d 
For deciding what action to
take we should evaluate where
we are going and not the current
active path.

Fixes vaadin/hilla#2726

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caalador caalador

Labels
bug Something isn't working hilla Issues related to Hilla Released with Vaadin 24.4.13
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Evaluate target not active vaadin/flow
2 participants
@caalador @vaadin-bot