feat: export Signals under own package #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cromoteca
force-pushed
the
feat/re-export-signals
branch
from
92f9353
to
8c94625
Compare
taefi
reviewed
Feb 8, 2024
taefi
reviewed
Feb 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 57 57
Lines 3861 3861
Branches 564 564
=======================================
Hits 3678 3678
Misses 147 147
Partials 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
platosha
previously approved these changes
Feb 13, 2024
platosha
previously approved these changes
Feb 14, 2024
platosha
added a commit
to vaadin/flow
that referenced
this pull request
Feb 20, 2024
Vite's esbuild JSX output in production has some incompatibility with the Preact Signals library. As a workaround, this change applies JSX transformation provided by `@vitejs/plugin-react` in production mode. Required by: vaadin/hilla#2043
platosha
added a commit
to vaadin/flow
that referenced
this pull request
Feb 21, 2024
Vite's esbuild JSX output in production has some incompatibility with the Preact Signals library. As a workaround, this change applies JSX transformation provided by `@vitejs/plugin-react` in production mode. Required by: vaadin/hilla#2043
|
platosha
approved these changes
Feb 22, 2024
|
This ticket/PR has been released with Hilla 24.4.0.alpha7 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2035