-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export Signals under own package #2043
Conversation
92f9353
to
8c94625
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 57 57
Lines 3861 3861
Branches 564 564
=======================================
Hits 3678 3678
Misses 147 147
Partials 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Vite's esbuild JSX output in production has some incompatibility with the Preact Signals library. As a workaround, this change applies JSX transformation provided by `@vitejs/plugin-react` in production mode. Required by: vaadin/hilla#2043
Vite's esbuild JSX output in production has some incompatibility with the Preact Signals library. As a workaround, this change applies JSX transformation provided by `@vitejs/plugin-react` in production mode. Required by: vaadin/hilla#2043
|
This ticket/PR has been released with Hilla 24.4.0.alpha7 and is also targeting the upcoming stable 24.4.0 version. |
Closes #2035